linux-kernel - Re: [PATCH V2 09/12] dtb: amd: Add KCS device tree node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56BA0FBA.1010202@amd.com>
Date:	Tue, 9 Feb 2016 10:11:38 -0600
From:	Brijesh Singh <brijesh.singh@....com>
To:	Arnd Bergmann <arnd@...db.de>,
	<linux-arm-kernel@...ts.infradead.org>
CC:	<brijesh.singh@....com>,
	Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>,
	<mark.rutland@....com>, <devicetree@...r.kernel.org>,
	<arm@...nel.org>, <pawel.moll@....com>,
	<ijc+devicetree@...lion.org.uk>, <linux-kernel@...r.kernel.org>,
	<robh+dt@...nel.org>, <leo.duran@....com>, <galak@...eaurora.org>,
	<thomas.lendacky@....com>, <brijeshkumar.singh@....com>
Subject: Re: [PATCH V2 09/12] dtb: amd: Add KCS device tree node

Hi,

On 02/09/2016 10:00 AM, Arnd Bergmann wrote:
> 
> The important part for interrupt/reg/... names is that you must use exactly the
> names that are listed in the binding. If there is no name in there, it's better
> not to add the name property.
> 
> The other point is that "ipmi_kcs" is a name that is picked really badly, as it
> uses a '_' character while DT properties by convention use '-' between names,
> and the name of the IRQ is the same as the device itself, which is really
> not a useful way to disambiguate multiple interrupts in the same device, if
> someone ever adds another irq line.
> 

Sure we will drop the name field. Thanks.

> 	Arnd
>