linux-kernel - Re: [PATCH] drm: fix missing reference counting decrease

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 9 Feb 2016 09:48:35 -0500
From:	Harry Wentland <harry.wentland@....com>
To:	Insu Yun <wuninsu@...il.com>, <airlied@...ux.ie>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
CC:	<yeongjin.jang@...ech.edu>, <taesoo@...ech.edu>, <insu@...ech.edu>,
	<changwoo@...ech.edu>, "Lysenko, Mykola" <Mykola.Lysenko@....com>,
	"Deucher, Alexander" <Alexander.Deucher@....com>
Subject: Re: [PATCH] drm: fix missing reference counting decrease

This looks good but we should probably do the same for all return paths 
when reference for port has been acquired.

Please see attached patch.

Thanks,
Harry

On 2016-02-01 11:08 AM, Insu Yun wrote:
> In drm_dp_mst_allocate_vcpi, it returns true in two paths,
> but in one path, there is no reference couting decrease.
>
> Signed-off-by: Insu Yun <wuninsu@...il.com>
> ---
>   drivers/gpu/drm/drm_dp_mst_topology.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 6ed90a2..fe273b6 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -2446,6 +2446,7 @@ bool drm_dp_mst_allocate_vcpi(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp
>   		DRM_DEBUG_KMS("payload: vcpi %d already allocated for pbn %d - requested pbn %d\n", port->vcpi.vcpi, port->vcpi.pbn, pbn);
>   		if (pbn == port->vcpi.pbn) {
>   			*slots = port->vcpi.num_slots;
> +			drm_dp_put_port(port);
>   			return true;
>   		}
>   	}


View attachment "0001-drm-dp-mst-Fix-missing-ref-count-decrease.patch" of type "text/x-patch" (1442 bytes)