linux-kernel - Re: [PATCH 2/6] ibmvscsi: Add and use enums for valid CRQ header values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56BA24E1.9090808@linux.vnet.ibm.com>
Date:	Tue, 9 Feb 2016 11:41:53 -0600
From:	Manoj Kumar <manoj@...ux.vnet.ibm.com>
To:	Tyrel Datwyler <tyreld@...ux.vnet.ibm.com>, JBottomley@...n.com
Cc:	martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, hare@...e.de,
	brking@...ux.vnet.ibm.com, nfont@...ux.vnet.ibm.com,
	linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 2/6] ibmvscsi: Add and use enums for valid CRQ header
 values

> Yeah, I can see how that is confusing. Since, all three possible valid
> crq message types have the first bit set I think this was originally a
> cute hack to grab anything that was likely valid. Then in
> ibmvscsi_handle_crq() we explicitly match the full header value in a
> switch statement logging anything that turned out actually invalid.
>
>>
>> If 'valid' will only have one of these four enums defined, would
>> this be better written as:
>>
>> 	if (crq->valid != VIOSRP_CRQ_FREE)
>
> This definitely would make the logic easier to read and follow. Also,
> this would make sure any crq with an invalid header that doesn't have
> its first bit set will also be logged by the ibmvscsi_handle_crq()
> switch statement default block and not silently ignored.
>
> -Tyrel

Sounds good, Tyrel. Does this mean I should expect a v2 of this patch
series?

- Manoj N. Kumar