linux-kernel - Re: [PATCH] clk: fix __clk_init_parent() for single parent clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160209181856.GB24167@codeaurora.org>
Date:	Tue, 9 Feb 2016 10:18:56 -0800
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:	linux-clk@...r.kernel.org,
	Michael Turquette <mturquette@...libre.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: fix __clk_init_parent() for single parent clocks

On 02/09, Masahiro Yamada wrote:
> Before commit b3d192d5121f ("clk: simplify __clk_init_parent()"),
> __clk_init_parent() called .get_parent() only for multi-parent
> clocks.  That commit changed the behavior to call .get_parent()
> if available even for single-parent clocks and root clocks.
> 
> It turned out a problem because there are some single-parent clocks
> that implement .get_parent() callback and return non-zero index.
> The SOCFPGA clock is the case; the commit broke the SOCFPGA boards.
> 
> To keep the original behavior, invoke .get_parent() only when
> num_parents is greater than 1.
> 
> Fixes: b3d192d5121f ("clk: simplify __clk_init_parent()")
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> Reported-by: Dinh Nguyen <dinguyen@...nsource.altera.com>
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project