linux-kernel - Re: [PATCH] net: ti: netcp: restore get/set_pad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4072312.pCFuaqSbhC@wuerfel>
Date:	Tue, 09 Feb 2016 20:38:19 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	"Karicheri, Muralidharan" <m-karicheri2@...com>
Cc:	David Laight <David.Laight@...lab.com>,
	"Strashko, Grygorii" <grygorii.strashko@...com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"David S . Miller" <davem@...emloft.net>,
	"Cooper Jr., Franklin" <fcooper@...com>,
	"Nori, Sekhar" <nsekhar@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Kwok, WingMan" <w-kwok2@...com>,
	"N, Mugunthan V" <mugunthanvnm@...com>
Subject: Re: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality

On Tuesday 09 February 2016 16:55:42 Karicheri, Muralidharan wrote:
> 
> The descriptors are usable by different drivers, one driver may use it as 
> buf ptr/ len, other for something else. So they should remain as generic
> and it is up to individual drivers to use it in whatever way it requires.
> My suggestion is to rename pad field in struct knav_dma_desc to sw_data
> to avoid confusion. i.e 
> 
> +       __le32  pad[4];
> 
> to 
> 
> +       __le32  sw_data[4];
> 

If the hardware doesn't access them, they can probably just be u32
and not do any byte swapping.

	Arnd