lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 09 Feb 2016 22:27:48 +0200 From: Jani Nikula <jani.nikula@...ux.intel.com> To: Rasmus Villemoes <linux@...musvillemoes.dk>, Daniel Vetter <daniel.vetter@...el.com>, David Airlie <airlied@...ux.ie> Cc: Rasmus Villemoes <linux@...musvillemoes.dk>, intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/5] drm/i915: fix error path in intel_setup_gmbus() On Tue, 09 Feb 2016, Rasmus Villemoes <linux@...musvillemoes.dk> wrote: > This fails to undo the setup for pin==0; moreover, something > interesting happens if the setup failed already at pin==0. > > Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk> > --- > drivers/gpu/drm/i915/intel_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c > index 25254b5c1ac5..deb8282c26d8 100644 > --- a/drivers/gpu/drm/i915/intel_i2c.c > +++ b/drivers/gpu/drm/i915/intel_i2c.c > @@ -683,7 +683,7 @@ int intel_setup_gmbus(struct drm_device *dev) > return 0; > > err: > - while (--pin) { > + while (pin--) { > if (!intel_gmbus_is_valid_pin(dev_priv, pin)) > continue; Reviewed-by: Jani Nikula <jani.nikula@...el.com> Fixes: f899fc64cda8 ("drm/i915: use GMBUS to manage i2c links") Cc: stable@...r.kernel.org -- Jani Nikula, Intel Open Source Technology Center
Powered by blists - more mailing lists