linux-kernel - Re: [PATCH v2 1/10] cpufreq: Clean up default and fallback governor setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160210054819.GB31787@in.ibm.com>
Date:	Wed, 10 Feb 2016 11:18:19 +0530
From:	Gautham R Shenoy <ego@...ux.vnet.ibm.com>
To:	Gautham R Shenoy <ego@...ux.vnet.ibm.com>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Linux PM list <linux-pm@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Viresh Kumar <viresh.kumar@...aro.org>,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	Juri Lelli <juri.lelli@....com>,
	Steve Muckle <steve.muckle@...aro.org>,
	Saravana Kannan <skannan@...eaurora.org>
Subject: Re: [PATCH v2 1/10] cpufreq: Clean up default and fallback governor
 setup

On Wed, Feb 10, 2016 at 10:45:14AM +0530, Gautham R Shenoy wrote:
> Hello Rafael,
> 
> On Fri, Feb 05, 2016 at 03:11:54AM +0100, Rafael J. Wysocki wrote:
> [..snip..]
> > Index: linux-pm/drivers/cpufreq/cpufreq_performance.c
> > ===================================================================
> > --- linux-pm.orig/drivers/cpufreq/cpufreq_performance.c
> > +++ linux-pm/drivers/cpufreq/cpufreq_performance.c
> > @@ -33,10 +33,7 @@ static int cpufreq_governor_performance(
> >  	return 0;
> >  }
> > 
> > -#ifdef CONFIG_CPU_FREQ_GOV_PERFORMANCE_MODULE
> > -static
> > -#endif
> > -struct cpufreq_governor cpufreq_gov_performance = {
> > +static struct cpufreq_governor cpufreq_gov_performance = {
> >  	.name		= "performance",
> >  	.governor	= cpufreq_governor_performance,
> >  	.owner		= THIS_MODULE,
> > @@ -52,6 +49,19 @@ static void __exit cpufreq_gov_performan
> >  	cpufreq_unregister_governor(&cpufreq_gov_performance);
> >  }
> > 
> > +#ifdef CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE
> > +struct cpufreq_governor *cpufreq_default_governor(void)
> > +{
> > +	return &cpufreq_gov_performance;
> > +}
> > +#endif
> > +#ifndef CONFIG_CPU_FREQ_GOV_PERFORMANCE_MODULE
> 
> Shouldn't this be #ifdef ?

Never mind! Shouldn't be reviewing patches first thing in the morning!

--
Thanks and Regards
gautham.