linux-kernel - Re: [PATCH] mmc: block: return error on failed mmc_blk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFoAGD2bsAxRm1nkk9r1SUv8oBPCTpYgoPGSu_vqYj6yMg@mail.gmail.com>
Date:	Wed, 10 Feb 2016 09:18:34 +0100
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Olof Johansson <olof@...om.net>
Cc:	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Grant Grundler <grundler@...gle.com>
Subject: Re: [PATCH] mmc: block: return error on failed mmc_blk_get()

On 9 February 2016 at 18:34, Olof Johansson <olof@...om.net> wrote:
> This used to return -EFAULT, but the function above returns -EINVAL on
> the same condition so let's stick to that.
>
> The removal of error return on this path was introduced with b093410c9aef
> ('mmc: block: copy resp[] data on err for MMC_IOC_MULTI_CMD').
>
> Fixes: b093410c9aef ('mmc: block: copy resp[] data on err for MMC_IOC_MULTI_CMD').
> Signed-off-by: Olof Johansson <olof@...om.net>
> Cc: Grant Grundler <grundler@...gle.com>

Thanks, applied for fixes!

Kind regards
Uffe

> ---
>  drivers/mmc/card/block.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index 57a5b6d..b3ec4fb 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -655,8 +655,10 @@ static int mmc_blk_ioctl_multi_cmd(struct block_device *bdev,
>         }
>
>         md = mmc_blk_get(bdev->bd_disk);
> -       if (!md)
> +       if (!md) {
> +               err = -EINVAL;
>                 goto cmd_err;
> +       }
>
>         card = md->queue.card;
>         if (IS_ERR(card)) {
> --
> 2.1.4
>