linux-kernel - Re: [PATCH 3/5] gpio: ath79: Make the driver removable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Feb 2016 11:13:38 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Alexandre Courbot <gnurou@...il.com>
Cc:	Alban Bedel <albeu@...e.fr>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Antony Pavlov <antonynpavlov@...il.com>,
	Gabor Juhos <juhosg@...nwrt.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/5] gpio: ath79: Make the driver removable

On Mon, Feb 8, 2016 at 4:04 AM, Alexandre Courbot <gnurou@...il.com> wrote:
> On Fri, Jan 29, 2016 at 4:44 AM, Alban Bedel <albeu@...e.fr> wrote:
>> As we now allow the driver to be built as a module it should be
>> removable.
>>
>> Signed-off-by: Alban Bedel <albeu@...e.fr>
>> ---
>>  drivers/gpio/gpio-ath79.c | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
>> index afb535e..6b15792 100644
>> --- a/drivers/gpio/gpio-ath79.c
>> +++ b/drivers/gpio/gpio-ath79.c
>> @@ -46,6 +46,7 @@ static int ath79_gpio_probe(struct platform_device *pdev)
>>         ctrl = devm_kzalloc(&pdev->dev, sizeof(*ctrl), GFP_KERNEL);
>>         if (!ctrl)
>>                 return -ENOMEM;
>> +       platform_set_drvdata(pdev, ctrl);
>>
>>         if (np) {
>>                 err = of_property_read_u32(np, "ngpios", &ath79_gpio_count);
>> @@ -97,12 +98,21 @@ static int ath79_gpio_probe(struct platform_device *pdev)
>>         return 0;
>>  }
>>
>> +static int ath79_gpio_remove(struct platform_device *pdev)
>> +{
>> +       struct ath79_gpio_ctrl *ctrl = platform_get_drvdata(pdev);
>
> platform_get_drvdata will return a gpio_chip *.

No it will return a struct ath79_gpio_ctrl * AFAICT.

bgpio will set the driver data to the gc but not when using generic gpio
as library like this driver does, only when it is used as a stand-alone device.

Yours,
Linus Walleij