linux-kernel - Re: [PATCH] w1: w1_process() is not freezable kthread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1602101140300.22727@cbobk.fhfr.pm>
Date:	Wed, 10 Feb 2016 11:41:08 +0100 (CET)
From:	Jiri Kosina <jikos@...nel.org>
To:	GregKH <greg@...ah.com>
cc:	Evgeniy Polyakov <zbr@...emap.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] w1: w1_process() is not freezable kthread

On Sun, 7 Feb 2016, GregKH wrote:

> I can't find this patch anywhere in my queue, can you please resend it
> to me with the ack so I can apply it?

Greg, please find it below. Thanks.





From: Jiri Kosina <jkosina@...e.cz>
Subject: [PATCH] w1: w1_process() is not freezable kthread

From: Jiri Kosina <jkosina@...e.cz>

w1_process() calls try_to_freeze(), but the thread doesn't mark itself 
freezable through set_freezable(), so the try_to_freeze() call is useless.

Acked-by: Evgeniy Polyakov <zbr@...emap.net>
Signed-off-by: Jiri Kosina <jkosina@...e.cz>
---
 drivers/w1/w1.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index c9a7ff6..89a7847 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -1147,7 +1147,6 @@ int w1_process(void *data)
 			jremain = 1;
 		}
 
-		try_to_freeze();
 		__set_current_state(TASK_INTERRUPTIBLE);
 
 		/* hold list_mutex until after interruptible to prevent loosing
-- 
Jiri Kosina
SUSE Labs