linux-kernel - Re: [PATCH v4 2/4] modules: set mod->state to MODULE_STATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160210123726.GG3305@pathway.suse.cz>
Date:	Wed, 10 Feb 2016 13:37:26 +0100
From:	Petr Mladek <pmladek@...e.com>
To:	Jessica Yu <jeyu@...hat.com>
Cc:	Josh Poimboeuf <jpoimboe@...hat.com>,
	Seth Jennings <sjenning@...hat.com>,
	Jiri Kosina <jikos@...nel.org>,
	Vojtech Pavlik <vojtech@...e.com>,
	Miroslav Benes <mbenes@...e.cz>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ingo Molnar <mingo@...hat.com>, live-patching@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/4] modules: set mod->state to MODULE_STATE_GOING
 before going notifiers are called

On Mon 2016-02-08 23:50:22, Jessica Yu wrote:
> In load_module(), the going notifiers are called during error handling when
> an error occurs after the coming notifiers have already been called.
> However, a module's state is still MODULE_STATE_COMING when the going
> notifiers are called in the error path. To be consistent, also set
> mod->state to MODULE_STATE_GOING before calling the going notifiers.
> 
> Signed-off-by: Jessica Yu <jeyu@...hat.com>

Reviewed-by: Petr Mladek <pmladek@...e.com>

It makes perfect sense to set the state this way. But note that it is
only partial win. We still stay in the COMING state when using the
other goto targets for the error handling, e.g. bug_cleanup,
ddebug_cleanup.

I was a bit nervous by such a change at this stage of 4.5 release.
I spent quite some time on checking various scenarios and I did
not find any problem with it.

Best Regards,
Petr