linux-kernel - Re: [PATCH] mmc: sh_mmcif: Correct TX DMA channel allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1505202.4RaxZJ1VUz@avalon>
Date:	Wed, 10 Feb 2016 16:36:29 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Chris Paterson <chris.paterson2@...esas.com>
Cc:	ulf.hansson@...aro.org, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org, kuninori.morimoto.gx@...esas.com,
	ykaneko0929@...il.com, arnd@...db.de, geert+renesas@...der.be,
	kouichi.tomita.yn@...esas.com, takeshi.kihara.df@...esas.com,
	koji.matsuoka.xm@...esas.com
Subject: Re: [PATCH] mmc: sh_mmcif: Correct TX DMA channel allocation

Hi Chris,

Thank you for the patch.

On Wednesday 10 February 2016 14:07:01 Chris Paterson wrote:
> Commit 27cbd7e815a8 ("mmc: sh_mmcif: rework dma channel handling")
> introduced a typo causing the TX DMA channel allocation to be overwritten
> by the requested RX DMA channel.
> 
> Signed-off-by: Chris Paterson <chris.paterson2@...esas.com>

Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/mmc/host/sh_mmcif.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
> index e0c076a..8d870ce 100644
> --- a/drivers/mmc/host/sh_mmcif.c
> +++ b/drivers/mmc/host/sh_mmcif.c
> @@ -445,7 +445,7 @@ static void sh_mmcif_request_dma(struct sh_mmcif_host
> *host) pdata->slave_id_rx);
>  	} else {
>  		host->chan_tx = dma_request_slave_channel(dev, "tx");
> -		host->chan_tx = dma_request_slave_channel(dev, "rx");
> +		host->chan_rx = dma_request_slave_channel(dev, "rx");
>  	}
>  	dev_dbg(dev, "%s: got channel TX %p RX %p\n", __func__, host->chan_tx,
>  		host->chan_rx);

-- 
Regards,

Laurent Pinchart