lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 Feb 2016 16:08:13 +0100 From: Oliver Neukum <oneukum@...e.de> To: Andy Shevchenko <andy.shevchenko@...il.com> Cc: Felipe Balbi <balbi@...nel.org>, Heikki Krogerus <heikki.krogerus@...ux.intel.com>, Mathias Nyman <mathias.nyman@...ux.intel.com>, Greg KH <gregkh@...uxfoundation.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, USB <linux-usb@...r.kernel.org> Subject: Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface On Wed, 2016-02-10 at 16:24 +0200, Andy Shevchenko wrote: > On Wed, Feb 10, 2016 at 4:15 PM, Oliver Neukum <oneukum@...e.com> wrote: > > On Wed, 2016-02-10 at 13:56 +0200, Andy Shevchenko wrote: > >> > +err: > >> > + if (i > 0) > >> > + for (; i >= 0; i--, con--) > >> > + typec_unregister_port(con->port); > >> > >> Perhaps > >> > >> while (--i >= 0) { > >> ... > >> } > > > > While we are at it. No we should not change the semantics > > of conditionals for the sake of appearance. > > I'm sorry I didn't get you. > How this more or less standard pattern to clean up stuff on error path > does with conditional semantics? You change a postdecrement to a predecrement. The highest number the loop is executed for is changed. Oliver
Powered by blists - more mailing lists