linux-kernel - Re: [PATCH v8] SATA: OCTEON: support SATA on OCTEON platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160210181649.GR3741@mtj.duckdns.org>
Date:	Wed, 10 Feb 2016 13:16:49 -0500
From:	Tejun Heo <tj@...nel.org>
To:	David Daney <ddaney@...iumnetworks.com>
Cc:	Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>,
	hdegoede@...hat.com, david.daney@...ium.com,
	aleksey.makarov@...iumnetworks.com, linux-kernel@...r.kernel.org,
	linux-ide@...r.kernel.org
Subject: Re: [PATCH v8] SATA: OCTEON: support SATA on OCTEON platform

On Wed, Feb 10, 2016 at 10:12:52AM -0800, David Daney wrote:
> On 02/10/2016 08:02 AM, Tejun Heo wrote:
> >On Tue, Feb 09, 2016 at 12:04:29PM +0000, Zubair Lutfullah Kakakhel wrote:
> >...
> >>  .../devicetree/bindings/ata/ahci-platform.txt      |   1 +
> >>  .../devicetree/bindings/mips/cavium/sata-uctl.txt  |  42 +++++++++
> >>  arch/mips/include/asm/octeon/cvmx.h                |   9 ++
> >>  drivers/ata/Kconfig                                |   9 ++
> >>  drivers/ata/Makefile                               |   1 +
> >>  drivers/ata/ahci_platform.c                        |   1 +
> >>  drivers/ata/sata_octeon.c                          | 105 +++++++++++++++++++++
> >
> >Don't we usually name these ahci variants ahci_xxx?
> >
> 
> Just to be clear, are you suggesting renaming sata_octeon.c to
> ahci_octeon.c?

Yeah, unless there are reasons not to.

Thanks.

-- 
tejun