linux-kernel - Re: [PATCH v11 3/4] ARM64: add SBSA Generic Watchdog device node in amd-seattle-soc.dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56BBA3F0.4010908@amd.com>
Date:	Thu, 11 Feb 2016 03:56:16 +0700
From:	Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
To:	<fu.wei@...aro.org>, <robh+dt@...nel.org>, <pawel.moll@....com>,
	<mark.rutland@....com>, <ijc+devicetree@...lion.org.uk>,
	<galak@...eaurora.org>, <wim@...ana.be>, <linux@...ck-us.net>,
	<corbet@....net>, <catalin.marinas@....com>, <will.deacon@....com>
CC:	<linux-kernel@...r.kernel.org>, <linux-watchdog@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linaro-acpi@...ts.linaro.org>, <rruigrok@...eaurora.org>,
	<harba@...eaurora.org>, <cov@...eaurora.org>,
	<timur@...eaurora.org>, <dyoung@...hat.com>, <panand@...hat.com>,
	<graeme.gregory@...aro.org>, <al.stone@...aro.org>,
	<hanjun.guo@...aro.org>, <jcm@...hat.com>, <arnd@...db.de>,
	<leo.duran@....com>, <sudeep.holla@....com>
Subject: Re: [PATCH v11 3/4] ARM64: add SBSA Generic Watchdog device node in
 amd-seattle-soc.dtsi

Hi Fu Wei,

On 2/10/16 00:00, fu.wei@...aro.org wrote:
> From: Fu Wei <fu.wei@...aro.org>
>
> This can be a example of adding SBSA Generic Watchdog device node
> into some dts files for the Soc which contains SBSA Generic Watchdog.
>
> Acked-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
> Signed-off-by: Fu Wei <fu.wei@...aro.org>
> ---
>   arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi b/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi
> index 2874d92..67eb636 100644
> --- a/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi
> +++ b/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi
> @@ -84,6 +84,15 @@
>   			clock-names = "uartclk", "apb_pclk";
>   		};
>
> +		watchdog0: watchdog@...b0000 {
> +			compatible = "arm,sbsa-gwdt";
> +			reg = <0x0 0xe0bc0000 0 0x1000>,
> +				<0x0 0xe0bb0000 0 0x1000>;
> +			interrupts = <0 337 4>;
> +			timeout-sec = <15>;
> +			status = "disabled";

Could you please remove this status line? I do not think it is necessary 
for this one here anymore.

Thanks,
Suravee

> +		};
> +
>   		spi0: ssp@...20000 {
>   			status = "disabled";
>   			compatible = "arm,pl022", "arm,primecell";
>