linux-kernel - Regression: ABI: /sys/module/mmcblk changed to /sys/module/mmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 10 Feb 2016 23:29:24 -0800
From:	John Stultz <john.stultz@...aro.org>
To:	Ulf Hansson <ulf.hansson@...aro.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Greg KH <gregkh@...uxfoundation.org>
Subject: Regression: ABI: /sys/module/mmcblk changed to /sys/module/mmc_block

I recently noticed with 4.4 based kernel's Android's userspace wasn't
able to properly detect micro-SD cards when they were inserted.

This is due to vold not being able to access
/sys/module/mmcblk/parameters/perdev_minors

See: http://androidxref.com/6.0.1_r10/xref/system/vold/Disk.cpp#49

Looking into it, it seems commit 829b6962f7e3cfc ("mmc: block: don't
use parameter prefix if built as module") changed the behavior,
resulting in the userspace path changing to:
"/sys/module/mmc_block/..."

This seems like an ABI regression, which is breaking existing userspace.

So... Probably something to revert?

thanks
-john