linux-kernel - Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vd1CvX--4afiMXXdyfyF9SaKCRjYZs1uUnKjoCiOqYBnQ@mail.gmail.com>
Date:	Thu, 11 Feb 2016 10:26:31 +0200
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Bjørn Mork <bjorn@...k.no>
Cc:	Oliver Neukum <oneukum@...e.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Felipe Balbi <balbi@...nel.org>,
	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	USB <linux-usb@...r.kernel.org>
Subject: Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface

On Wed, Feb 10, 2016 at 5:11 PM, Bjørn Mork <bjorn@...k.no> wrote:
> Andy Shevchenko <andy.shevchenko@...il.com> writes:
>> On Wed, Feb 10, 2016 at 3:21 PM, Oliver Neukum <oneukum@...e.com> wrote:
>>> On Wed, 2016-02-10 at 13:56 +0200, Andy Shevchenko wrote:
>>>> > +out:
>>>>
>>>> CodingStyle suggests to do a better label naming.

[...]

> Exactly what is it about "out" that is unclear to you here?  Could you
> propose a better alternative if you seriously mean that this needs to be
> changed?

Those switches of course an extra stuff, but I would propose
out_connect:

To me out: sounds out, like printing error and return code, or
something like that. Here the case is different.

And since we have two full switches it might be hard to have on one
screen out code and exact goto. See my point now?

-- 
With Best Regards,
Andy Shevchenko