| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20160211085146.GX27969@c203.arch.suse.de> Date: Thu, 11 Feb 2016 09:51:46 +0100 From: Johannes Thumshirn <jthumshirn@...e.de> To: Tyrel Datwyler <tyreld@...ux.vnet.ibm.com> Cc: james.bottomley@...senpartnership.com, martin.petersen@...cle.com, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, nfont@...ux.vnet.ibm.com, brking@...ux.vnet.ibm.com, manoj@...ux.vnet.ibm.com Subject: Re: [PATCH v2 2/7] ibmvscsi: Add and use enums for valid CRQ header values On Wed, Feb 10, 2016 at 07:32:23PM -0600, Tyrel Datwyler wrote: > The PAPR defines four valid header values for the first byte of a > CRQ message. Namely, an unused/empty message (0x00), a valid > command/response entry (0x80), a valid initialization entry (0xC0), > and a valid transport event (0xFF). Further, initialization responses > have two formats namely initialize (0x01) and initialize complete > (0x02). Define these values as enums and use them in the code in > place of their magic number equivalents. > > Signed-off-by: Tyrel Datwyler <tyreld@...ux.vnet.ibm.com> Reviewed-by: Johannes Thumshirn <jthumshirn@...e.de> -- Johannes Thumshirn Storage jthumshirn@...e.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Powered by blists - more mailing lists