linux-kernel - Re: [PATCH] cifs: fix erroneous return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH2r5msGBsAX49vtd-3H=NKH5-WGU8=b=m1oodiZ98GMwxFocQ@mail.gmail.com>
Date:	Wed, 10 Feb 2016 18:25:13 -0600
From:	Steve French <smfrench@...il.com>
To:	Anton Protopopov <a.s.protopopov@...il.com>
Cc:	Steve French <sfrench@...ba.org>,
	"linux-cifs@...r.kernel.org" <linux-cifs@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cifs: fix erroneous return value

Merged into cifs-2.6.git and added cc: stable

On Wed, Feb 10, 2016 at 11:50 AM, Anton Protopopov
<a.s.protopopov@...il.com> wrote:
> The setup_ntlmv2_rsp() function may return positive value ENOMEM instead
> of -ENOMEM in case of kmalloc failure.
>
> Signed-off-by: Anton Protopopov <a.s.protopopov@...il.com>
> ---
>  fs/cifs/cifsencrypt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c
> index afa09fc..e682b36 100644
> --- a/fs/cifs/cifsencrypt.c
> +++ b/fs/cifs/cifsencrypt.c
> @@ -714,7 +714,7 @@ setup_ntlmv2_rsp(struct cifs_ses *ses, const struct nls_table *nls_cp)
>
>         ses->auth_key.response = kmalloc(baselen + tilen, GFP_KERNEL);
>         if (!ses->auth_key.response) {
> -               rc = ENOMEM;
> +               rc = -ENOMEM;
>                 ses->auth_key.len = 0;
>                 goto setup_ntlmv2_rsp_ret;
>         }
> --
> 2.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Thanks,

Steve