linux-kernel - Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16626.1455184286@warthog.procyon.org.uk>
Date:	Thu, 11 Feb 2016 09:51:26 +0000
From:	David Howells <dhowells@...hat.com>
To:	Tadeusz Struk <tadeusz.struk@...el.com>
Cc:	dhowells@...hat.com, herbert@...dor.apana.org.au,
	linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	linux-crypto@...r.kernel.org, zohar@...ux.vnet.ibm.com
Subject: Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api

Tadeusz Struk <tadeusz.struk@...el.com> wrote:

> > Why didn't you put the RSA signature parsing - ie. where the OID and the other
> > bits are checked - into crypto/rsa.c?
> > 
> 
> Do you want to get rid of the crypto/asymmetric_keys/rsa.c completely?
> I wanted to make the conversion churn as small as possible.
> I can move it in a subsequent patch if you want.

I was thinking of getting rid of it completely, yes.

But I was wondering if you had some other motivation, such as keeping the
crypto layer purely the mathematical operation.

It's an interesting question where to draw the line, actually.  The answer may
hinge on what things like the TPM do.  I should ask the TPM folks.

David