linux-kernel - Re: [PATCH] drm/msm: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160211104921.GT11240@phenom.ffwll.local>
Date:	Thu, 11 Feb 2016 11:49:21 +0100
From:	Daniel Vetter <daniel@...ll.ch>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Daniel Vetter <daniel.vetter@...ll.ch>,
	David Airlie <airlied@...ux.ie>,
	linux-arm-kernel@...ts.infradead.org,
	Rob Clark <robdclark@...il.com>,
	David Herrmann <dh.herrmann@...il.com>,
	Stéphane Marchesin <marcheu@...omium.org>,
	Haixia Shi <hshi@...omium.org>,
	Archit Taneja <architt@...eaurora.org>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/msm: remove unused variable

On Thu, Feb 11, 2016 at 10:10:00AM +0100, Arnd Bergmann wrote:
> After the drm_device_is_unplugged() was removed, the 'dev' variable is now
> unused, and we get a warning for that:
> 
> drivers/gpu/drm/msm/msm_fbdev.c: In function 'msm_fbdev_mmap':
> drivers/gpu/drm/msm/msm_fbdev.c:65:21: error: unused variable 'dev' [-Werror=unused-variable]
> 
> This removes the variable as well.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: e9f8250f2f92 ("drm/msm: remove the drm_device_is_unplugged check")

Applied, thanks.
-Daniel

> ---
>  drivers/gpu/drm/msm/msm_fbdev.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
> index e119c2979509..d9759bf3482e 100644
> --- a/drivers/gpu/drm/msm/msm_fbdev.c
> +++ b/drivers/gpu/drm/msm/msm_fbdev.c
> @@ -62,7 +62,6 @@ static int msm_fbdev_mmap(struct fb_info *info, struct vm_area_struct *vma)
>  	struct drm_fb_helper *helper = (struct drm_fb_helper *)info->par;
>  	struct msm_fbdev *fbdev = to_msm_fbdev(helper);
>  	struct drm_gem_object *drm_obj = fbdev->bo;
> -	struct drm_device *dev = helper->dev;
>  	int ret = 0;
>  
>  	ret = drm_gem_mmap_obj(drm_obj, drm_obj->size, vma);
> -- 
> 2.7.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch