linux-kernel - Re: [PATCH] gpio: add tps65218 gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZqZ946xQcnh_cmGgx4P4_ovSk7HQWuwnzZtJUzFw8n3Q@mail.gmail.com>
Date:	Thu, 11 Feb 2016 12:25:57 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Nicolas Saenz Julienne <nicolassaenzj@...il.com>
Cc:	Alexandre Courbot <gnurou@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: add tps65218 gpio

On Sat, Jan 30, 2016 at 6:06 PM, Nicolas Saenz Julienne
<nicolassaenzj@...il.com> wrote:

> Driver for the GPIO block found in ti's tps65218 pmics.
>
> The device has two GPIOs and one GPO pin which can be configured as follows:
> GPIO1:
>         -general-purpose, open-drain output controlled by GPO1 user bit and/or
>          sequencer
>         -DDR3 reset input signal from SOC. Signal is either latched or
>          passed-trough to GPO2 pin. See below for details.
> GPO2:
>         -general-purpose output controlled by GPO2 user bit
>         -DDR3 reset output signal. Signal is controlled by GPIO1 and PGOOD.
>          See below for details.
>         -Output buffer can be configured as open-drain or push-pull.
> GPIO3:
>         -general-purpose, open-drain output controlled by GPO3 user bit and/or
>          sequencer
>         -reset input-signal for DCDC1 and DCDC2.
>
> The input configurations are not meant to be used by the user so the driver
> only offers GPOs.
>
> v2: Added request routine that evaluates the fw config flags and removed module
>     owner
> v3: Added .direction_input() routine, and took care of all Linus Walleij
> suggestions (clamp to bool, use proper include)
>
> Signed-off-by: Nicolas Saenz Julienne <nicolassaenzj@...il.com>

OK nice! Patch applied.

Yours,
Linus Walleij