linux-kernel - Re: [PATCH net-next v7 15/19] net: bridge: use __ethtool_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160210165846.0e7ae670@xeon-e3>
Date:	Wed, 10 Feb 2016 16:58:46 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	David Decotigny <ddecotig@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Ben Hutchings <ben@...adent.org.uk>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-api@...r.kernel.org, linux-mips@...ux-mips.org,
	fcoe-devel@...n-fcoe.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tejun Heo <tj@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
	Eugenia Emantayev <eugenia@...lanox.co.il>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Ido Shamay <idos@...lanox.com>, Joe Perches <joe@...ches.com>,
	Saeed Mahameed <saeedm@...lanox.com>,
	Govindarajulu Varadarajan <_govind@....com>,
	Venkata Duvvuru <VenkatKumar.Duvvuru@...lex.Com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	Pravin B Shelar <pshelar@...ira.com>,
	Ed Swierk <eswierk@...portsystems.com>,
	Robert Love <robert.w.love@...el.com>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	Yuval Mintz <Yuval.Mintz@...gic.com>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	David Decotigny <decot@...glers.com>
Subject: Re: [PATCH net-next v7 15/19] net: bridge: use
 __ethtool_get_ksettings

On Sun,  7 Feb 2016 17:08:59 -0800
David Decotigny <ddecotig@...il.com> wrote:

> From: David Decotigny <decot@...glers.com>
> 
> Signed-off-by: David Decotigny <decot@...glers.com>
> ---
>  net/bridge/br_if.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
> index c367b3e..cafe4e6 100644
> --- a/net/bridge/br_if.c
> +++ b/net/bridge/br_if.c
> @@ -36,10 +36,10 @@
>   */
>  static int port_cost(struct net_device *dev)
>  {
> -	struct ethtool_cmd ecmd;
> +	struct ethtool_ksettings ecmd;
>  
> -	if (!__ethtool_get_settings(dev, &ecmd)) {
> -		switch (ethtool_cmd_speed(&ecmd)) {
> +	if (!__ethtool_get_ksettings(dev, &ecmd)) {
> +		switch (ecmd.parent.speed) {
>  		case SPEED_10000:
>  			return 2;
>  		case SPEED_1000:

Sure looks fine for bridge.
This reminds me that bridge code needs to transition to this decade
and do latest STP.

Acked-by: Stephen Hemminger <stephen@...workplumber.org>