linux-kernel - Re: [PATCH 1/3] usb: USB Type-C Connector Class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160211143616.GE32213@kuha.fi.intel.com>
Date:	Thu, 11 Feb 2016 16:36:16 +0200
From:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:	Felipe Balbi <balbi@...nel.org>
Cc:	Oliver Neukum <oneukum@...e.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 1/3] usb: USB Type-C Connector Class

Hi Felipe,

> >> 4. partner_alt_modes - Lists partner's Alternate Modes when connected
> 
> partner_alternate_modes ? (it's a file name, we can spell it out)
> 
> >> 5. partner_type - Can be USB, Charger, Alt Mode or Accessory
> >> 6. data_role - The current data role, host or device
> >> 7. data_roles - Data roles supported by the connector
> 
> current_data_role
> available_data_roles
> 
> >> 8. power_role - Connector's current power role, source or sink
> >> 9. power_roles - Power roles supported by the connector
> 
> ditto...
> 
> >> 10. power_operation_mode - The current power level in use
> >> 11. usb_pd - yes if the connector supports USB PD.
> 
> supports_usb_power_delivery ?
> 
> >> 12. audio_accessory - yes if the connector supports Audio Accessory
> 
> supports_audio_accessory
> 
> >> 13. debug_accessory - yes if the connector supports Debug Accessory
> 
> supports_debug_accessory

Those all make sense.

> > Doesn't this need locking?
> > And why wouldn't user space want to preselect a mode?
> 
> isn't USB always the default mode ?

Just in case there are no misunderstandings here, Oliver was
commenting on alternate_mode_store function, and USB of course is not
Alternate Mode.


Thanks,

-- 
heikki