linux-kernel - Re: [PATCH] null_blk: oops when initializing without lightnvm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56BCAF2C.6030809@kernel.dk>
Date:	Thu, 11 Feb 2016 08:56:28 -0700
From:	Jens Axboe <axboe@...nel.dk>
To:	Matias Bjørling <m@...rling.me>,
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
	axboe@...com
Subject: Re: [PATCH] null_blk: oops when initializing without lightnvm

On 02/11/2016 06:49 AM, Matias Bjørling wrote:
> If the LightNVM subsystem is not compiled into the kernel, and the
> null_blk device driver requests lightnvm to be initialized. The call to
> nvm_register fails and the null_add_dev function cleans up the
> initialization. However, at this point the null block device has
> already been added to the nullb_list and thus a second cleanup will
> occur when the function has returned, that leads to a double call to
> blk_cleanup_queue.

Deferring the add seems fine, applied for 4.5.

-- 
Jens Axboe