linux-kernel - Re: [PATCH] rdma: amso1100: c2_provider: Use netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56BCB66F.4070305@redhat.com>
Date:	Thu, 11 Feb 2016 11:27:27 -0500
From:	Doug Ledford <dledford@...hat.com>
To:	Amitoj Kaur Chawla <amitoj1606@...il.com>, sean.hefty@...el.com,
	hal.rosenstock@...il.com, gregkh@...uxfoundation.org,
	linux-rdma@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Cc:	julia.lawall@...6.fr
Subject: Re: [PATCH] rdma: amso1100: c2_provider: Use netdev_dbg()

On 02/06/2016 10:11 AM, Amitoj Kaur Chawla wrote:
> Replace generic pr_debug() with netdev_dbg() for net devices.
> 
> Found using Coccinelle. The semantic patch used to find this is as
> follows:
> 
> //<smpl>
> @@
> expression e;
> identifier f,i;
> position p;
> @@
> 
> f(...,struct net_device *i,...) {
>   ...
> -  pr_debug@p(e);
> +  netdev_dbg(i, e);
>   ...
> }
> //</smpl>
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com>

This driver has been removed entire as of 4.5-rc2, so this patch can no
longer be applied.

> ---
>  drivers/staging/rdma/amso1100/c2_provider.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rdma/amso1100/c2_provider.c b/drivers/staging/rdma/amso1100/c2_provider.c
> index e44ad22..75a7de5 100644
> --- a/drivers/staging/rdma/amso1100/c2_provider.c
> +++ b/drivers/staging/rdma/amso1100/c2_provider.c
> @@ -659,7 +659,7 @@ static int c2_pseudo_up(struct net_device *netdev)
>  	if (!ind)
>  		return 0;
>  
> -	pr_debug("adding...\n");
> +	netdev_dbg(netdev, "adding...\n");
>  	for_ifa(ind) {
>  #ifdef DEBUG
>  		u8 *ip = (u8 *) & ifa->ifa_address;
> @@ -684,7 +684,7 @@ static int c2_pseudo_down(struct net_device *netdev)
>  	if (!ind)
>  		return 0;
>  
> -	pr_debug("deleting...\n");
> +	netdev_dbg(netdev, "deleting...\n");
>  	for_ifa(ind) {
>  #ifdef DEBUG
>  		u8 *ip = (u8 *) & ifa->ifa_address;
> 


-- 
Doug Ledford <dledford@...hat.com>
              GPG KeyID: 0E572FDD



Download attachment "signature.asc" of type "application/pgp-signature" (885 bytes)