linux-kernel - Re: [PATCH] misc: panel, convert struct to bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160211171237.GP25328@haproxy.com>
Date:	Thu, 11 Feb 2016 18:12:37 +0100
From:	Willy TARREAU <wtarreau@...roxy.com>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	gregkh@...uxfoundation.org, arnd@...db.de,
	linux-kernel@...r.kernel.org,
	Daniel Chromik <daniel.chromik@...nam.cz>,
	Ksenija Stanojevic <ksenija.stanojevic@...il.com>
Subject: Re: [PATCH] misc: panel, convert struct to bitmap

On Thu, Feb 11, 2016 at 01:29:23PM +0100, Jiri Slaby wrote:
> From: Daniel Chromik <daniel.chromik@...nam.cz>
> 
> There is an anonymous struct which is actually used as a bitmap. So
> convert the struct to a bitmap and change code accordingly where
> needed.
> 
> This also allows for a cleanup of set_data_bits and set_ctrl_bits as
> they can use a common helper now. The helper can also be converted to
> a for loop instead of doing bit OR. And given it is a for loop now,
> bit masking (using BIT_MSK) is moved from the callers there too.
> 
> Signed-off-by: Daniel Chromik <daniel.chromik@...nam.cz>
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Willy Tarreau <willy@...roxy.com>
> Cc: Ksenija Stanojevic <ksenija.stanojevic@...il.com>

Acked-by: Willy Tarreau <willy@...roxy.com>

Thanks,
Willy