linux-kernel - Re: [PATCH RESEND] mmc:host:Fix error handling for calls to the function shdci_runtime_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <90967.1455214088@turing-police.cc.vt.edu>
Date:	Thu, 11 Feb 2016 13:08:08 -0500
From:	Valdis.Kletnieks@...edu
To:	Adrian Hunter <adrian.hunter@...el.com>
Cc:	Nicholas Krause <xerofoify@...il.com>, ulf.hansson@...aro.org,
	ludovic.desroches@...el.com, ivan.ivanov@...aro.org,
	sbranden@...adcom.com, haibo.chen@...escale.com,
	jszhang@...vell.com, marex@...x.de, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] mmc:host:Fix error handling for calls to the function shdci_runtime_pm_get in the file sdhci.c

On Thu, 11 Feb 2016 10:06:04 +0200, Adrian Hunter said:
> On 10/02/16 16:34, Nicholas Krause wrote:
> > This fixes error handling for various function calls to

> pm_runtime_resume() returns 1 if the device's runtime PM status was already
> 'active', and -EACCES means that 'power.disable_depth' is different from 0
> (i.e. runtime pm not enabled), so this does not look coded correctly for
> those cases.

I wonder if Nicholas has a different meaning of the word "fixes".

Seriously Nicholas - you're wasting maintainer resources with all these
broken patches.  Please stop doing it.


Content of type "application/pgp-signature" skipped