linux-kernel - Re: [RFC v1 6/8] x86/init: use linker table for i386 early setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAB=NE6WXwqGtN+pPCcmdQpn2M3-8hQawoD=qYpmVQEYtiEuo2Q@mail.gmail.com>
Date:	Thu, 11 Feb 2016 11:55:01 -0800
From:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Andy Lutomirski <luto@...capital.net>,
	Michael Brown <mcb30@...e.org>,
	Juergen Gross <jgross@...e.com>,
	Jan Beulich <JBeulich@...e.com>,
	Joerg Roedel <joro@...tes.org>,
	Andrey Ryabinin <ryabinin.a.a@...il.com>,
	long.wanglong@...wei.com, qiuxishi@...wei.com,
	aryabinin@...tuozzo.com,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Valentin Rothberg <valentinrothberg@...il.com>,
	Peter Senna Tschudin <peter.senna@...il.com>,
	X86 ML <x86@...nel.org>,
	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC v1 6/8] x86/init: use linker table for i386 early setup

On Wed, Jan 20, 2016 at 1:41 PM, Luis R. Rodriguez
<mcgrof@...not-panic.com> wrote:
> On Wed, Jan 20, 2016 at 1:14 PM, Konrad Rzeszutek Wilk
> <konrad.wilk@...cle.com> wrote:
>> On Tue, Dec 15, 2015 at 02:16:35PM -0800, Luis R. Rodriguez wrote:
>>> From: "Luis R. Rodriguez" <mcgrof@...e.com>
>>>
>>> This also annotates this is only used for PC and
>>> lguest hardware subarchitectures.
>>>
>>> Signed-off-by: Luis R. Rodriguez <mcgrof@...e.com>
>>
>> On Xen the code path (before this patch) was:
>> xen_start_kernel->i386_start_kernel->i386_default_early_setup
>>
>> and now you remove the i386_default_early_setup call?
>
> No you're right, this should include the Xen subarch as well, thanks for that.

FYI - I've mended this fix into my upcoming v2 series, I've also made
a separate patch to make annotate the XEN subarch on the PV guest boot
path (xen_start_kernel()). While at it, I'll go and also add an
extension of documentation to the subarch based on the conversations
on this thread, and make lguest explicitly use LGUEST subarch rather
than just the digit.

 Luis