linux-kernel - Re: [PATCH] PM / OPP: Fix NULL pointer dereference when no regulator is defined

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 11 Feb 2016 22:17:15 +0100
From:	"Rafael J. Wysocki" <rafael@...nel.org>
To:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc:	Viresh Kumar <viresh.kumar@...aro.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Lists linaro-kernel <linaro-kernel@...ts.linaro.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Nishanth Menon <nm@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Len Brown <len.brown@...el.com>,
	open list <linux-kernel@...r.kernel.org>,
	Pavel Machek <pavel@....cz>, Viresh Kumar <vireshk@...nel.org>,
	Rafael Wysocki <rjw@...ysocki.net>
Subject: Re: [PATCH] PM / OPP: Fix NULL pointer dereference when no regulator
 is defined

On Thu, Feb 11, 2016 at 5:13 PM, Bartlomiej Zolnierkiewicz
<b.zolnierkie@...sung.com> wrote:
> Commit 7d34d56ef334 ("PM / OPP: Disable OPPs that aren't
> supported by the regulator") causes NULL pointer dereference
> OOPS when no regulator for OPP is defined.  Fix it by
> replacing IS_ERR() check with IS_ERR_OR_NULL() one (since
> providing regulator for OPP is optional).
>
> Cc: Viresh Kumar <viresh.kumar@...aro.org>
> Cc: Stephen Boyd <sboyd@...eaurora.org>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> Fixes: 7d34d56ef334 ("PM / OPP: Disable OPPs that aren't supported by the regulator")
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> ---
> This fixes linux-pm/linux-next tree boot hang regression on
> Exynos4412 SoC based Odroid-U3 board.
>
> Rafael, please apply.  Thank you!

This has been fixed by an identical patch from Jon Hunter I received earlier.

Thanks,
Rafael