linux-kernel - Re: [PATCH] Revert "mmc: block: don't use parameter prefix if built as module"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Feb 2016 13:52:26 -0800
From:	John Stultz <john.stultz@...aro.org>
To:	Ulf Hansson <ulf.hansson@...aro.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	Greg KH <gregkh@...uxfoundation.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH] Revert "mmc: block: don't use parameter prefix if built
 as module"

On Thu, Feb 11, 2016 at 7:57 AM, Ulf Hansson <ulf.hansson@...aro.org> wrote:
> On 11 February 2016 at 16:54, Ulf Hansson <ulf.hansson@...aro.org> wrote:
>> This reverts commit 829b6962f7e3cfc06f7c5c26269fd47ad48cf503.
>>
>> Revert this change as it causes a sysfs path to change and therefore
>> introduces and ABI regression. More precisely Android's vold is not being
>> able to access /sys/module/mmcblk/parameters/perdev_minors any more, since
>> the path becomes changed to: "/sys/module/mmc_block/..."
>>
>> Fixes: 829b6962f7e3 ("mmc: block: don't use parameter prefix if built as
>> module")
>> Reported-by: John Stultz <john.stultz@...aro.org>
>> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>> Signed-off-by: Ulf Hansson <ulf.hansson@...aro.org>
>
> John, I noticed your regression report. Thanks!
>
> I decided to send this patch and I have already queued it for fixes.
>
> Sorry for not thinking clear when I applied the earlier patch.

Don't worry, those sorts of changes are subtle. I've seen a lot of
funny sysfs path breakage recently, but usually they are in paths that
are device specific (often related to the paths I think changed in the
dts - ie: lots of paths now have .../soc/... in them), so its not too
hard to just fix it for the device.

This one was more painful because it was generic path across all
devices. So I'm just glad to have caught it before the new behavior
became established and we'd be a bit stuck having to support both.

thanks
-john