linux-kernel - Re: [PATCH 2/4] mailbox: mailbox-test: fix the compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Feb 2016 09:08:37 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Sudeep Holla <sudeep.holla@....com>
Cc:	Jassi Brar <jassisinghbrar@...il.com>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] mailbox: mailbox-test: fix the compatible string

On Thu, 11 Feb 2016, Sudeep Holla wrote:

> Underscores are usually forbidden in the compatible strings. So lets
> remove it before the first users of this is seen.
> 
> Cc: Jassi Brar <jassisinghbrar@...il.com>
> Cc: Lee Jones <lee.jones@...aro.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@....com>

Acked-by: Lee Jones <lee.jones@...aro.org>

> ---
>  Documentation/devicetree/bindings/mailbox/sti-mailbox.txt | 2 +-
>  drivers/mailbox/mailbox-test.c                            | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt b/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt
> index b61eec920359..351f612673fc 100644
> --- a/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt
> +++ b/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt
> @@ -44,7 +44,7 @@ Optional properties
>  Example:
>  
>  mailbox_test {
> -	compatible	= "mailbox_test";
> +	compatible	= "mailbox-test";
>  	reg		= <0x[shared_memory_address], [shared_memory_size]>;
>  	mboxes		= <&mailbox2 0 1>, <&mailbox0 2 1>;
>  	mbox-names	= "tx",	"rx";
> diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c
> index 3813f6d9eba9..036a852b5fa1 100644
> --- a/drivers/mailbox/mailbox-test.c
> +++ b/drivers/mailbox/mailbox-test.c
> @@ -342,7 +342,7 @@ static int mbox_test_remove(struct platform_device *pdev)
>  }
>  
>  static const struct of_device_id mbox_test_match[] = {
> -	{ .compatible = "mailbox_test" },
> +	{ .compatible = "mailbox-test" },
>  	{},
>  };
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog