linux-kernel - Re: [PATCH 2/2] kernel: sched: fix preempt_disable_ip recodring for preempt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Feb 2016 19:45:38 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	kbuild test robot <lkp@...el.com>
Cc:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	kbuild-all@...org, Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] kernel: sched: fix preempt_disable_ip recodring for
 preempt_disable()

On Fri, 12 Feb 2016 08:27:01 +0800
kbuild test robot <lkp@...el.com> wrote:

> Hi Sebastian,
> 
> [auto build test ERROR on tip/sched/core]
> [also build test ERROR on v4.5-rc3 next-20160211]
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
> 

Gotta love Wu's autobot!

> url:    https://github.com/0day-ci/linux/commits/Sebastian-Andrzej-Siewior/ftrace-move-the-CALLER_ADDRx-macros-into-its-own-header/20160212-072259
> config: s390-allyesconfig (attached as .config)
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=s390 
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from include/linux/ftrace_caller.h:4:0,
>                     from include/linux/sched.h:62,
>                     from include/linux/kvm_host.h:15,
>                     from arch/s390/kernel/asm-offsets.c:10:
>    arch/s390/include/asm/ftrace.h: In function 'ftrace_generate_call_insn':
> >> arch/s390/include/asm/ftrace.h:77:2: error: implicit declaration of function 'is_module_addr' [-Werror=implicit-function-declaration]  
>      target = is_module_addr((void *) ip) ? ftrace_plt : FTRACE_ADDR;
>      ^
>    In file included from include/linux/mm.h:67:0,
>                     from include/linux/kvm_host.h:17,
>                     from arch/s390/kernel/asm-offsets.c:10:
>    arch/s390/include/asm/pgtable.h: At top level:
> >> arch/s390/include/asm/pgtable.h:120:19: error: static declaration of 'is_module_addr' follows non-static declaration  
>     static inline int is_module_addr(void *addr)

Looks like you need to add this? (maybe)

-- Steve

diff --git a/arch/s390/include/asm/ftrace.h b/arch/s390/include/asm/ftrace.h
index 836c56290499..16f24f92609d 100644
--- a/arch/s390/include/asm/ftrace.h
+++ b/arch/s390/include/asm/ftrace.h
@@ -12,6 +12,8 @@
 
 #ifndef __ASSEMBLY__
 
+#include <linux/module.h>
+
 #define ftrace_return_address(n) __builtin_return_address(n)
 
 void _mcount(void);