linux-kernel - Re: [RFC PATCH] perf hists: Do column alignment on the format iterator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160212125622.GB16190@krava.redhat.com>
Date:	Fri, 12 Feb 2016 13:56:22 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	Dave Jones <davej@...emonkey.org.uk>, Jiri Olsa <jolsa@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	linux-perf-users@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] perf hists: Do column alignment on the format
 iterator

On Thu, Feb 11, 2016 at 05:27:18PM -0300, Arnaldo Carvalho de Melo wrote:

SNIP

>  		int column = 0;
>  
>  		hist_browser__gotorc(browser, row, 0);
>  
>  		hists__for_each_format(browser->hists, fmt) {
> +			struct perf_hpp hpp = {
> +				.buf	= s,
> +				.size	= sizeof(s),
> +				.ptr	= &arg,
> +			};
> +
>  			if (perf_hpp__should_skip(fmt, entry->hists) ||
>  			    column++ < browser->b.horiz_scroll)
>  				continue;
> @@ -1122,8 +1123,9 @@ static int hist_browser__show_entry(struct hist_browser *browser,
>  			if (fmt->color) {
>  				width -= fmt->color(fmt, &hpp, entry);
>  			} else {
> -				width -= fmt->entry(fmt, &hpp, entry);
> +				hist_entry__snprintf_alignment(entry, &hpp, fmt, fmt->entry(fmt, &hpp, entry));
>  				ui_browser__printf(&browser->b, "%s", s);
> +				width -= hpp.buf - s;

how's the 'color' case handled?

jirka