linux-kernel - Re: [PATCH net-next] net: macb: add wake-on-lan support via magic packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160212151620.GA25399@rob-hp-laptop>
Date:	Fri, 12 Feb 2016 09:16:20 -0600
From:	Rob Herring <robh@...nel.org>
To:	Sergio Prado <sergio.prado@...abworks.com>
Cc:	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	nicolas.ferre@...el.com, davem@...emloft.net,
	gregory.clement@...e-electrons.com, narmstrong@...libre.com,
	michal.simek@...inx.com, harini.katakam@...inx.com,
	boris.brezillon@...e-electrons.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: macb: add wake-on-lan support via magic
 packet

On Tue, Feb 09, 2016 at 12:07:16PM -0200, Sergio Prado wrote:
> Tested on Acqua A5 SoM (http://www.acmesystems.it/acqua).
> 
> Signed-off-by: Sergio Prado <sergio.prado@...abworks.com>
> ---
>  Documentation/devicetree/bindings/net/macb.txt |  2 +
>  drivers/net/ethernet/cadence/macb.c            | 67 +++++++++++++++++++++++---
>  drivers/net/ethernet/cadence/macb.h            |  4 ++
>  3 files changed, 67 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
> index d2e243b1ec0e..c6b1cb5ffa87 100644
> --- a/Documentation/devicetree/bindings/net/macb.txt
> +++ b/Documentation/devicetree/bindings/net/macb.txt
> @@ -25,6 +25,8 @@ Required properties:
>  
>  Optional properties for PHY child node:
>  - reset-gpios : Should specify the gpio for phy reset
> +- cdns,magic-packet : If present, indicates that the hardware supports waking
> +  up via magic packet.

Already have one vendor property like this (fsl). Make this a generic 
property.

Rob