[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20160212031807.GC10157@kroah.com>
Date: Thu, 11 Feb 2016 19:18:07 -0800
From: Greg KH <gregkh@...uxfoundation.org>
To: Christian Brauner <christian.brauner@...lbox.org>
Cc: tj@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] let kernfs_name_locked & kernfs_name return size_t
On Wed, Feb 10, 2016 at 08:07:05PM +0100, Christian Brauner wrote:
> Simple patch that changes the return value of kernfs_name_locked and kernfs_name
> to size_t which alignes these functions with kernfs_path_len which also returns
> size_t.
>
> Patch was made against for-4.5 branch of Tejun's cgroup tree. (As per Tejun's
> request, ccing gregkh@...uxfoundation.org and linux-kernel@...r.kernel.org.)
>
> Changelog
> 20150210: - Change return type of kernfs_name in kernfs.h as well.
> - Build tested against Tejun's for-4.5 tree, 4.5-rc2 and
> mainline 4.5-rc3.
>
> *Note*, the changes in kernfs.h change the dummy return value of the static
> inline definition of kernfs_name from -ENOSYS. I changed it to 0 analogous to
> kernfs_path_len. I don't know if this is considered a deal-breaker.
Please don't change that, that's a behavior change, not just a "cleanup
the return type" change.
thanks,
greg k-h
Powered by blists - more mailing lists