linux-kernel - Re: [PATCH 06/11] staging: lustre: add missing spaces for LNet layer reported by checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1455298503.4235.4.camel@perches.com>
Date:	Fri, 12 Feb 2016 09:35:03 -0800
From:	Joe Perches <joe@...ches.com>
To:	James Simmons <jsimmons@...radead.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org,
	Andreas Dilger <andreas.dilger@...el.com>,
	Oleg Dorkin <oleg.dorkin@...el.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Lustre Development List <lustre-devel@...ts.lustre.org>
Subject: Re: [PATCH 06/11] staging: lustre: add missing spaces for LNet
 layer reported by checkpatch.pl

On Fri, 2016-02-12 at 12:06 -0500, James Simmons wrote:
> Add missing spaces in the code reported by checkpatch.pl.
[]
> diff --git a/drivers/staging/lustre/include/linux/lnet/lib-types.h b/drivers/staging/lustre/include/linux/lnet/lib-types.h
[]
> @@ -112,7 +112,7 @@ typedef struct lnet_libhandle {
>  } lnet_libhandle_t;
>  
>  #define lh_entry(ptr, type, member) \
> -	((type *)((char *)(ptr)-(char *)(&((type *)0)->member)))
> +	((type *)((char *)(ptr) - (char *)(&((type *)0)->member)))

This could use offsetof(type, member)