linux-kernel - Re: [PATCH] vfio: fix link failures when CONFIG_PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160212111758.4b5cb926@t450s.home>
Date:	Fri, 12 Feb 2016 11:17:58 -0700
From:	Alex Williamson <alex.williamson@...hat.com>
To:	Luis Henriques <luis.henriques@...onical.com>
Cc:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: Re: [PATCH] vfio: fix link failures when CONFIG_PCI_MSI is disabled

On Wed, 3 Feb 2016 20:51:08 +0000
Luis Henriques <luis.henriques@...onical.com> wrote:

> The following link failure occurs when CONFIG_PCI_MSI is not set:
> 
> drivers/built-in.o: In function `vfio_msi_set_vector_signal':
> :(.text+0x626640): undefined reference to `pci_write_msi_msg'
> 
> Signed-off-by: Luis Henriques <luis.henriques@...onical.com>
> ---
>  drivers/vfio/pci/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vfio/pci/Kconfig b/drivers/vfio/pci/Kconfig
> index 02912f180c6d..b9dbfc9aeee1 100644
> --- a/drivers/vfio/pci/Kconfig
> +++ b/drivers/vfio/pci/Kconfig
> @@ -1,6 +1,6 @@
>  config VFIO_PCI
>  	tristate "VFIO support for PCI devices"
> -	depends on VFIO && PCI && EVENTFD
> +	depends on VFIO && PCI_MSI && EVENTFD
>  	select VFIO_VIRQFD
>  	select IRQ_BYPASS_MANAGER
>  	help
> 


It seems like a better solution would be to have pci stub these out
with static inlines when !CONFIG_PCI_MSI, we already do that for quite
a lot of MSI and MSI-X callbacks.  MSI/X on the device clearly won't
work if the host doesn't support MSI, and maybe there are improvements
to be made there, but MSI is a subcomponent of vfio-pci, the module
itself shouldn't depend on MSI.  Thanks,

Alex