linux-kernel - Re: [PATCH linux-next v4 07/11] MIPS: bcm63xx: nvram: Remove unused bcm63xx_nvram_get_psi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 12 Feb 2016 10:53:47 -0800
From:	Brian Norris <computersforpeace@...il.com>
To:	Simon Arlott <simon@...e.lp0.eu>,
	Ralf Baechle <ralf@...ux-mips.org>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	Kevin Cernekee <cernekee@...il.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Jonas Gorski <jogo@...nwrt.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	MIPS Mailing List <linux-mips@...ux-mips.org>,
	MTD Maling List <linux-mtd@...ts.infradead.org>,
	sfr@...b.auug.org.au
Subject: Re: [PATCH linux-next v4 07/11] MIPS: bcm63xx: nvram: Remove unused
 bcm63xx_nvram_get_psi_size() function

Hi Ralf,

On Tue, Jan 26, 2016 at 11:16:07AM -0800, Brian Norris wrote:
> On Sun, Dec 13, 2015 at 10:50:13PM +0000, Simon Arlott wrote:
> > Remove bcm63xx_nvram_get_psi_size() as it now has no users.
> > 
> > Signed-off-by: Simon Arlott <simon@...e.lp0.eu>
> > ---
> > v4: New patch.
> 
> Ralf,
> 
> Please revert this and send it to Linus (or else, I can send it myself).
> This is causing build failures, because I didn't take the rest of
> Simon's series yet.
> 
> drivers/mtd/bcm63xxpart.c: In function 'bcm63xx_parse_cfe_partitions':
> drivers/mtd/bcm63xxpart.c:93:2: error: implicit declaration of function 'bcm63xx_nvram_get_psi_size' [-Werror=implicit-function-declaration]
> 
> I will reply to the series if/when I accept any patches from it. I would
> appreciate it if you would do the same.

I see that the revert made it to Linus. Thanks!

I've now pushed the dependent pieces to l2-mtd.git, and they should make
it to v4.6-rc1. So I guess it's fair game to re-apply this patch?
Although, if you don't merge in my MTD branch first, you'd still be
breaking bisectability... Maybe it's a post-rc1 candidate?

Brian