linux-kernel - [PATCH] mtd: bcm63xxpart: give width specifier an 'int', not 'size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1455308764-47289-1-git-send-email-computersforpeace@gmail.com>
Date:	Fri, 12 Feb 2016 12:26:04 -0800
From:	Brian Norris <computersforpeace@...il.com>
To:	<linux-mtd@...ts.infradead.org>
Cc:	Simon Arlott <simon@...e.lp0.eu>,
	Brian Norris <computersforpeace@...il.com>,
	<linux-kernel@...r.kernel.org>
Subject: [PATCH] mtd: bcm63xxpart: give width specifier an 'int', not 'size_t'

Fixes this warning:

>> drivers/mtd/bcm63xxpart.c:175:4: note: in expansion of macro 'pr_err'
       pr_err("invalid rootfs address: %*ph\n",
       ^
>> include/linux/kern_levels.h:4:18: warning: field width specifier '*' expects argument of type 'int', but argument 2 has type 'long unsigned int' [-Wformat=]

Reported-by: kbuild test robot <fengguang.wu@...el.com>
Signed-off-by: Brian Norris <computersforpeace@...il.com>
---
 drivers/mtd/bcm63xxpart.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/mtd/bcm63xxpart.c b/drivers/mtd/bcm63xxpart.c
index 26c38a107576..41d1d3149c61 100644
--- a/drivers/mtd/bcm63xxpart.c
+++ b/drivers/mtd/bcm63xxpart.c
@@ -157,7 +157,7 @@ static int bcm63xx_parse_cfe_nor_partitions(struct mtd_info *master,
 		if (kstrtouint(buf->flash_image_start, 10, &rootfsaddr) ||
 				rootfsaddr < BCM963XX_EXTENDED_SIZE) {
 			pr_err("invalid rootfs address: %*ph\n",
-				sizeof(buf->flash_image_start),
+				(int)sizeof(buf->flash_image_start),
 				buf->flash_image_start);
 			goto invalid_tag;
 		}
@@ -166,7 +166,7 @@ static int bcm63xx_parse_cfe_nor_partitions(struct mtd_info *master,
 		if (kstrtouint(buf->kernel_address, 10, &kerneladdr) ||
 				kerneladdr < BCM963XX_EXTENDED_SIZE) {
 			pr_err("invalid kernel address: %*ph\n",
-				sizeof(buf->kernel_address),
+				(int)sizeof(buf->kernel_address),
 				buf->kernel_address);
 			goto invalid_tag;
 		}
@@ -174,7 +174,7 @@ static int bcm63xx_parse_cfe_nor_partitions(struct mtd_info *master,
 		STR_NULL_TERMINATE(buf->kernel_length);
 		if (kstrtouint(buf->kernel_length, 10, &kernellen)) {
 			pr_err("invalid kernel length: %*ph\n",
-				sizeof(buf->kernel_length),
+				(int)sizeof(buf->kernel_length),
 				buf->kernel_length);
 			goto invalid_tag;
 		}
@@ -182,7 +182,7 @@ static int bcm63xx_parse_cfe_nor_partitions(struct mtd_info *master,
 		STR_NULL_TERMINATE(buf->total_length);
 		if (kstrtouint(buf->total_length, 10, &totallen)) {
 			pr_err("invalid total length: %*ph\n",
-				sizeof(buf->total_length),
+				(int)sizeof(buf->total_length),
 				buf->total_length);
 			goto invalid_tag;
 		}
-- 
2.7.0.rc3.207.g0ac5344