linux-kernel - RE: [lustre-devel] [PATCH 5/7] staging:lustre: simplify libcfs_psdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7d92389fd1ca47abb762b460f4d9b7b6@EXCHCS32.ornl.gov>
Date:	Fri, 12 Feb 2016 23:16:02 +0000
From:	"Simmons, James A." <simmonsja@...l.gov>
To:	'Greg Kroah-Hartman' <gregkh@...uxfoundation.org>,
	James Simmons <jsimmons@...radead.org>
CC:	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"Parinay Kondekar" <parinay.kondekar@...gate.com>,
	James Simmons <uja.ornl@...oo.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Oleg Drokin <oleg.drokin@...el.com>,
	"lustre-devel@...ts.lustre.org" <lustre-devel@...ts.lustre.org>
Subject: RE: [lustre-devel] [PATCH 5/7] staging:lustre: simplify
	libcfs_psdev_[open|release]

>> diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-module.c b/drivers/staging/lustre/lustre/libcfs/linux/linux-module.c
>> index 33f6036..64f0fbf 100644
>> --- a/drivers/staging/lustre/lustre/libcfs/linux/linux-module.c
>> +++ b/drivers/staging/lustre/lustre/libcfs/linux/linux-module.c
>> @@ -98,30 +98,22 @@ int libcfs_ioctl_popdata(void *arg, void *data, int size)
>>  static int
>>  libcfs_psdev_open(struct inode *inode, struct file *file)
>>  {
>> -	int    rc = 0;
>> -
>>  	if (!inode)
>>  		return -EINVAL;
>> -	if (libcfs_psdev_ops.p_open != NULL)
>> -		rc = libcfs_psdev_ops.p_open(0, NULL);
>> -	else
>> -		return -EPERM;
>> -	return rc;
>> +
>> +	try_module_get(THIS_MODULE);
>
>Note, code like this is racy and incorrect and never needed, please fix
>this up properly (hint, set the module in the file operations.)
>
>Again, if you ever see code with that line, it is incorrect.

So simple

static struct file_operations libcfs_fops = {
        .module  = THIS_MODULE,
        .unlocked_ioctl = libcfs_psdev_ioctl,
};

With the open and release deleted should do the trick then.