linux-kernel - [PATCH] exofs: fix inode formatting, should be %llx and not %llu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1455394765-4490-1-git-send-email-colin.king@canonical.com>
Date:	Sat, 13 Feb 2016 20:19:25 +0000
From:	Colin King <colin.king@...onical.com>
To:	Boaz Harrosh <ooo@...ctrozaur.com>,
	Benny Halevy <bhalevy@...marydata.com>, osd-dev@...n-osd.org
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] exofs: fix inode formatting, should be %llx and not %llu

From: Colin Ian King <colin.king@...onical.com>

The inode is printed with a %llu format specifier when the
intention is to print a hexadecimal value. Trivial fix to
use %llx instead.  Found with smatch static analysis:

fs/exofs/dir.c:138 exofs_check_page() warn: '0x' prefix is
  confusing together with '%llu' specifier

Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 fs/exofs/dir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/exofs/dir.c b/fs/exofs/dir.c
index e5bb2ab..9a8eba6 100644
--- a/fs/exofs/dir.c
+++ b/fs/exofs/dir.c
@@ -137,7 +137,7 @@ Espan:
 bad_entry:
 	EXOFS_ERR(
 		"ERROR [exofs_check_page]: bad entry in directory(0x%lx): %s - "
-		"offset=%lu, inode=0x%llu, rec_len=%d, name_len=%d\n",
+		"offset=%lu, inode=0x%llx, rec_len=%d, name_len=%d\n",
 		dir->i_ino, error, (page->index<<PAGE_CACHE_SHIFT)+offs,
 		_LLU(le64_to_cpu(p->inode_no)),
 		rec_len, p->name_len);
-- 
2.7.0