linux-kernel - Re: [PATCH] midi: avoid freeing umidi object twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hoabldmu0.wl-tiwai@suse.de>
Date:	Sat, 13 Feb 2016 09:41:11 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	"Andrey Konovalov" <andreyknvl@...il.com>
Cc:	<alsa-devel@...a-project.org>,
	"Clemens Ladisch" <clemens@...isch.de>,
	"Jaroslav Kysela" <perex@...ex.cz>, <linux-kernel@...r.kernel.org>,
	<dvyukov@...gle.com>, <glider@...gle.com>, <kcc@...gle.com>
Subject: Re: [PATCH] midi: avoid freeing umidi object twice

On Sat, 13 Feb 2016 09:08:06 +0100,
Andrey Konovalov wrote:
> 
> The 'umidi' object will be free'd on the error path by snd_usbmidi_free()
> when tearing down the rawmidi interface. So we shouldn't try to free it
> in snd_usbmidi_create() after having registered the rawmidi interface.
> 
> Found by KASAN.
> 
> Acked-by: Clemens Ladisch <clemens@...isch.de>
> Signed-off-by: Andrey Konovalov <andreyknvl@...il.com>

Thanks, applied now with Cc to stable.


Takashi

> ---
>  sound/usb/midi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/usb/midi.c b/sound/usb/midi.c
> index cc39f63..007cf58 100644
> --- a/sound/usb/midi.c
> +++ b/sound/usb/midi.c
> @@ -2455,7 +2455,6 @@ int snd_usbmidi_create(struct snd_card *card,
>  	else
>  		err = snd_usbmidi_create_endpoints(umidi, endpoints);
>  	if (err < 0) {
> -		snd_usbmidi_free(umidi);
>  		return err;
>  	}
>  
> -- 
> 1.9.1
> 
>