linux-kernel - Re: [PATCH 1/3] net: cavium: liquidio: Return correct error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160213.055821.121289885645162222.davem@davemloft.net>
Date:	Sat, 13 Feb 2016 05:58:21 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	amitoj1606@...il.com
Cc:	derek.chickles@...iumnetworks.com,
	satananda.burla@...iumnetworks.com,
	felix.manlunas@...iumnetworks.com,
	raghu.vatsavayi@...iumnetworks.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, julia.lawall@...6.fr
Subject: Re: [PATCH 1/3] net: cavium: liquidio: Return correct error code

From: Amitoj Kaur Chawla <amitoj1606@...il.com>
Date: Thu, 4 Feb 2016 19:25:13 +0530

> The return value of vmalloc on failure of allocation of memory should
> be -ENOMEM and not -1.
> 
> Found using Coccinelle. A simplified version of the semantic patch
> used is:
 ...
> The single call site of the containing function checks whether the
> returned value is -1, so this check is changed as well. The single call 
> site of this call site, however, only checks whether the value is not 0,
> so no further change was required.
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com>

Applied.