linux-kernel - Re: [PATCH] net: cavium: liquidio: fix check for in progress flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160213.060640.863091898671472122.davem@davemloft.net>
Date:	Sat, 13 Feb 2016 06:06:40 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	colin.king@...onical.com
Cc:	derek.chickles@...iumnetworks.com,
	satananda.burla@...iumnetworks.com,
	felix.manlunas@...iumnetworks.com,
	raghu.vatsavayi@...iumnetworks.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: cavium: liquidio: fix check for in progress flag

From: Colin King <colin.king@...onical.com>
Date: Fri,  5 Feb 2016 16:30:39 +0000

> From: Colin Ian King <colin.king@...onical.com>
> 
> smatch detected a suspicious looking bitop condition:
> 
> drivers/net/ethernet/cavium/liquidio/lio_main.c:2529
>   handle_timestamp() warn: suspicious bitop condition
> 
> (skb_shinfo(skb)->tx_flags | SKBTX_IN_PROGRESS is always non-zero,
> so the logic is definitely not correct.  Use & to mask the correct
> bit.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks.

But this means one of the code paths was never tested...