linux-kernel - Re: [RESEND v7 1/5] mfd: hi655x: Add document for mfd hi665x PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 14 Feb 2016 09:38:42 +0800
From:	Chen Feng <puck.chen@...ilicon.com>
To:	Lee Jones <lee.jones@...aro.org>
CC:	<kong.kongxinwei@...ilicon.com>, <w.f@...wei.com>,
	<linux-kernel@...r.kernel.org>, <lgirdwood@...il.com>,
	<broonie@...nel.org>, <yudongbin@...ilicon.com>,
	<saberlily.xia@...ilicon.com>, <suzhuangluan@...ilicon.com>,
	<xuyiping@...ilicon.com>, <z.liuxinliang@...ilicon.com>,
	<puck.chenfeng@...il.com>, <weidong2@...ilicon.com>,
	<puck.chen@...mail.com>, <qijiwen@...ilicon.com>,
	<peter.panshilin@...ilicon.com>, <dan.zhao@...ilicon.com>,
	<linuxarm@...wei.com>, <haojian.zhuang@...aro.org>
Subject: Re: [RESEND v7 1/5] mfd: hi655x: Add document for mfd hi665x PMIC

Thanks for your review.

On 2016/2/12 0:59, Lee Jones wrote:
> On Mon, 01 Feb 2016, Chen Feng wrote:
> 
>> DT bindings for hisilicon hi655x MFD PMIC chip.
>>
>> Signed-off-by: Chen Feng <puck.chen@...ilicon.com>
>> Signed-off-by: Fei Wang <w.f@...wei.com>
>> Signed-off-by: Xinwei Kong <kong.kongxinwei@...ilicon.com>
>> Reviewed-by: Haojian Zhuang <haojian.zhuang@...aro.org>
>> ---
>>  .../devicetree/bindings/mfd/hisilicon,hi655x.txt   | 27 ++++++++++++++++++++++
>>  1 file changed, 27 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
>> new file mode 100644
>> index 0000000..5edc310
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
>> @@ -0,0 +1,27 @@
>> +Hisilicon hi655x Power Management Integrated Circuit (PMIC)
>> +
>> +The hardware layout for access PMIC Hi655x from AP SoC Hi6220.
>> +Between PMIC Hi655x and Hi6220, the physical signal channel is SSI.
>> +We can use memory-mapped I/O to communicate.
>> +
>> ++----------------+             +-------------+
>> +|                |             |             |
>> +|    Hi6220      |   SSI bus   |   Hi655x    |
>> +|                |-------------|             |
>> +|                |(REGMAP_MMIO)|             |
>> ++----------------+             +-------------+
>> +
>> +Required properties:
>> +- compatible: Should be "hisilicon,hi655x-pmic"
>> +- reg: Base address of PMIC on hi6220 soc
> 
> s/hi6220 soc/Hi6220 SoC/
> 
>> +- interrupt-controller: Hi655x has internal IRQs (has own IRQ domain).
>> +- pmic-gpios: The gpio used by PMIC irq.
> 
> s/gpio/GPIO/
> s/irq/IRQ/
> 

I will change this and send a new V8 version.

> These are always easier to read in this format:
> 
> - compatible:			Should be "hisilicon,hi655x-pmic"
> - reg:				Base address of PMIC on hi6220 soc
> - interrupt-controller: 	Hi655x has internal IRQs (has own IRQ domain).
> - pmic-gpios:			The gpio used by PMIC irq.
> 
>> +Example:
>> +	pmic: pmic@...00000 {
>> +		compatible = "hisilicon,hi655x-pmic";
>> +		reg = <0x0 0xf8000000 0x0 0x1000>;
>> +		interrupt-controller;
>> +		#interrupt-cells = <2>;
>> +		pmic-gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>;
>> +	}
>