lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 14 Feb 2016 14:22:19 -0800 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: linux-kernel@...r.kernel.org Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org, Stephan Mueller <smueller@...onox.de>, Herbert Xu <herbert@...dor.apana.org.au> Subject: [PATCH 4.4 102/117] crypto: shash - Fix has_key setting 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Herbert Xu <herbert@...dor.apana.org.au> commit 00420a65fa2beb3206090ead86942484df2275f3 upstream. The has_key logic is wrong for shash algorithms as they always have a setkey function. So we should instead be testing against shash_no_setkey. Fixes: a5596d633278 ("crypto: hash - Add crypto_ahash_has_setkey") Reported-by: Stephan Mueller <smueller@...onox.de> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au> Tested-by: Stephan Mueller <smueller@...onox.de> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> --- crypto/shash.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) --- a/crypto/shash.c +++ b/crypto/shash.c @@ -354,11 +354,10 @@ int crypto_init_shash_ops_async(struct c crt->final = shash_async_final; crt->finup = shash_async_finup; crt->digest = shash_async_digest; + crt->setkey = shash_async_setkey; + + crt->has_setkey = alg->setkey != shash_no_setkey; - if (alg->setkey) { - crt->setkey = shash_async_setkey; - crt->has_setkey = true; - } if (alg->export) crt->export = shash_async_export; if (alg->import)
Powered by blists - more mailing lists