lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 14 Feb 2016 08:51:48 +0530 From: Niranjan Dighe <niranjan.dighe@...il.com> To: Oleg Drokin <oleg.drokin@...el.com>, Andreas Dilger <andreas.dilger@...el.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Shivani Bhardwaj <shivanib134@...il.com>, Dmitry Eremin <dmitry.eremin@...el.com>, Mike Rapoport <mike.rapoport@...il.com>, Shraddha Barke <shraddha.6596@...il.com>, Frank Zago <fzago@...y.com>, Hatice ERTÜRK <haticeerturk27@...il.com>, Mike Shuey <shuey@...due.edu> Cc: lustre-devel@...ts.lustre.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: [PATCH] staging: lustre/lnet: Fix wrong typecasting warning generated by sparse Fix the following warning generated about type casting by sparse warning: cast removes address space of expression The current implementation casts the structure pointers with (char *) without __user annotation and then adds sizeof struct to it, thereby generating the sparse warning. Fixed this by removing the unnecessary char pointer type cast. Signed-off-by: Niranjan Dighe <niranjan.dighe@...il.com> --- drivers/staging/lustre/lnet/selftest/console.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/drivers/staging/lustre/lnet/selftest/console.c index 366211e..bc236c9 100644 --- a/drivers/staging/lustre/lnet/selftest/console.c +++ b/drivers/staging/lustre/lnet/selftest/console.c @@ -1460,10 +1460,8 @@ lstcon_statrpc_readent(int transop, srpc_msg_t *msg, return 0; sfwk_stat = (sfw_counters_t __user *)&ent_up->rpe_payload[0]; - srpc_stat = (srpc_counters_t __user *) - ((char *)sfwk_stat + sizeof(*sfwk_stat)); - lnet_stat = (lnet_counters_t __user *) - ((char *)srpc_stat + sizeof(*srpc_stat)); + srpc_stat = (srpc_counters_t __user *)(sfwk_stat + 1); + lnet_stat = (lnet_counters_t __user *)(srpc_stat + 1); if (copy_to_user(sfwk_stat, &rep->str_fw, sizeof(*sfwk_stat)) || copy_to_user(srpc_stat, &rep->str_rpc, sizeof(*srpc_stat)) || -- 1.9.1
Powered by blists - more mailing lists