linux-kernel - [PATCH] cpupower: fix potential memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1455436745-22444-1-git-send-email-arjun024@gmail.com>
Date:	Sun, 14 Feb 2016 13:29:05 +0530
From:	Arjun Sreedharan <arjun024@...il.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Dominik Brodowski <linux@...inikbrodowski.net>
Cc:	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] cpupower: fix potential memory leak

Signed-off-by: Arjun Sreedharan <arjun024@...il.com>
---
 tools/power/cpupower/bench/parse.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/tools/power/cpupower/bench/parse.c b/tools/power/cpupower/bench/parse.c
index f503fb5..058a351 100644
--- a/tools/power/cpupower/bench/parse.c
+++ b/tools/power/cpupower/bench/parse.c
@@ -65,7 +65,7 @@ FILE *prepare_output(const char *dirname)
 {
 	FILE *output = NULL;
 	int len;
-	char *filename;
+	char *filename, *filename_tmp;
 	struct utsname sysdata;
 	DIR *dir;
 
@@ -80,17 +80,19 @@ FILE *prepare_output(const char *dirname)
 	}
 
 	len = strlen(dirname) + 30;
-	filename = malloc(sizeof(char) * len);
+	filename = malloc(sizeof(*filename) * len);
 
 	if (uname(&sysdata) == 0) {
 		len += strlen(sysdata.nodename) + strlen(sysdata.release);
-		filename = realloc(filename, sizeof(char) * len);
+		filename_tmp = realloc(filename, sizeof(*filename) * len);
 
-		if (filename == NULL) {
+		if (filename_tmp == NULL) {
+			free(filename);
 			perror("realloc");
 			return NULL;
 		}
 
+		filename = filename_tmp;
 		snprintf(filename, len - 1, "%s/benchmark_%s_%s_%li.log",
 			dirname, sysdata.nodename, sysdata.release, time(NULL));
 	} else {
-- 
2.4.5