linux-kernel - Re: [PATCH v3 1/6] pinctrl: qcom: ipq4019: Add IPQ4019 pinctrl support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 14 Feb 2016 16:41:12 -0800
From:	Bjorn Andersson <bjorn@...o.se>
To:	Matthew McClintock <mmcclint@....qualcomm.com>,
	Linus Walleij <linus.walleij@...aro.org>
Cc:	Andy Gross <agross@...eaurora.org>,
	linux-arm-msm <linux-arm-msm@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Varadarajan Narayanan <varada@...eaurora.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	qca-upstream.external@....qualcomm.com,
	Sricharan R <sricharan@...eaurora.org>,
	Mathieu Olivari <mathieu@...eaurora.org>,
	Matthew McClintock <mmcclint@...eaurora.org>
Subject: Re: [PATCH v3 1/6] pinctrl: qcom: ipq4019: Add IPQ4019 pinctrl support

On Thu, Nov 19, 2015 at 3:19 PM, Matthew McClintock
<mmcclint@....qualcomm.com> wrote:
> From: Varadarajan Narayanan <varada@...eaurora.org>
>
> Add pinctrl driver support for IPQ4019 platform
>
> Signed-off-by: Sricharan R <sricharan@...eaurora.org>
> Signed-off-by: Mathieu Olivari <mathieu@...eaurora.org>
> Signed-off-by: Varadarajan Narayanan <varada@...eaurora.org>
> Signed-off-by: Matthew McClintock <mmcclint@...eaurora.org>
> ---

I was asked to review this, to make sure that Linus wasn't waiting for
my ack or anything. But now I see that you have not added him as a
recipient. Please make sure to run ./scripts/get_maintainer.pl and
pick appropriate recipients in the future.

>
> v3
> - update example with actual values from dts
> - add missing pins 71-99
> - drop many functions and stick to basic functionality
>

I hope to see a patch later on adding all those functions back, but
that's fine with me.

[..]

> +static struct platform_driver ipq4019_pinctrl_driver = {
> +       .driver = {
> +               .name = "ipq4019-pinctrl",
> +               .owner = THIS_MODULE,

platform_drivers do get their .owner assigned by platform_drive_register().

> +               .of_match_table = ipq4019_pinctrl_of_match,
> +       },
> +       .probe = ipq4019_pinctrl_probe,
> +       .remove = msm_pinctrl_remove,
> +};

Part of the .owner above you have my
Acked-by: Bjorn Andersson <bjorn.andersson@...aro.org>

@Linus, this still applies and builds cleanly on linux-next.
Would you be okay dropping the owner assignment while applying this patch?

Regards,
Bjorn